Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upgrade electron to latest version #3569

Closed
wants to merge 50 commits into from
Closed

WIP: Upgrade electron to latest version #3569

wants to merge 50 commits into from

Conversation

chrisbreiding
Copy link
Contributor

Closes #3568

@chrisbreiding chrisbreiding mentioned this pull request Feb 22, 2019
Closed
31 tasks
@chrisbreiding chrisbreiding changed the base branch from develop to v4.0 February 22, 2019 19:58
Saibamen
Saibamen suggested changes Feb 22, 2019
View reviewed changes
.node-version Outdated Show resolved Hide resolved
Saibamen
Saibamen suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@Saibamen Saibamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update this line: https://github.com/cypress-io/cypress/blob/develop/appveyor.yml#L10
and change comment to Test against the latest version of this Node.js version

Saibamen
Saibamen suggested changes Feb 25, 2019
View reviewed changes
.node-version Outdated Show resolved Hide resolved
@chrisbreiding chrisbreiding mentioned this pull request Apr 2, 2019
Closed
@chrisbreiding chrisbreiding changed the title WIP: Upgrade electron to 4.0.5 WIP: Upgrade electron to latest versoin Apr 5, 2019
@chrisbreiding chrisbreiding changed the title WIP: Upgrade electron to latest versoin WIP: Upgrade electron to latest version Apr 5, 2019
@chrisbreiding chrisbreiding mentioned this pull request May 21, 2019
Closed
18 tasks
@baer95
Copy link

baer95 commented May 21, 2019

From the recent changes in the v4 and v5 milestone issues it looks like the electron upgrade is planned to be merged for v4, but the merge target for this PR is still v5.0.

For which cypress release is the electron upgrade really planned?

@chrisbreiding
Copy link
Contributor Author

@baer95 The electron upgrade is planned for v4.0. Since this PR was originally based off what is now v5.0, it will be easier to merge it into that branch and cherry-pick it into v4.0 once it's ready.

The sources of truth for the changes in each release are the tracking issues: v4.0 and v5.0

@CLAassistant
Copy link

CLAassistant commented May 22, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

brian-mann
brian-mann reviewed May 28, 2019
View reviewed changes
appveyor.yml Outdated Show resolved Hide resolved
@chrisbreiding
Copy link
Contributor Author

Closing in favor of #4354, which targets the 4.0 release.

@chrisbreiding chrisbreiding deleted the issue-3568-upgrade-electron branch March 2, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann brian-mann left review comments

@Saibamen Saibamen Saibamen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chrisbreiding @Joelasaur @baer95 @CLAassistant @Saibamen @brian-mann @kuceb @flotwig