Add ability to zoom in / out in Electron browser

[jennifer-shehane]

• Adds ability to zoom in / out in Electron browser + specs view using View menu or keyboard shortcuts.
• tested manually also 👍
• close Implement zoom in Test Runner #1231

Can zoom this

Can also zoom this in Electron browser

[flotwig]

There's a failing test in /root/cypress/packages/server/test/unit/gui/menu_spec.coffee

[brian-mann]

When you are decaffeinating files - you must decaffeinate the files first AND submit a PR for that separately.

As it stands - there is no easy way to tell the actual "diff" between the changes you made to menu.coffee and menu.js or menu_spec.coffee and menu_spec.js since menu.coffee and menu_spec.coffee were first deleted.

To be clear - you don't have to submit these PR's serially. You can go ahead and decaffeinate locally first - and continue working as normal. But once you're "finished" you need to then open another PR (off of develop) and decaffeinate the files you ended up decaffeinating.

This second PR can then be merged, and then the first PR will correctly show the diff against the decaffeinated files in develop. Ask @bkucera if you have any questions since he does this on a regular basis. I will do this for you this time.

[jennifer-shehane]

@brian-mann This should be clearly documented somewhere - as I thought there was a process in line, but never was told it, but from what I can tell you:

1. Rename the file from .coffee to .js and commit (do not decaffeinate yet).
2. Decaffeinate the .js file and commit.
3. Clean up any issues / eslinting of new .js file and commit.
4. Now make any changes you wanted to make from the original issue/PR you were trying to address.

decaffeinate was done in other PR for menus

[jennifer-shehane]

The only failure is the one caused by cypress.io - which is known, so merging in with this failure.

[brian-mann]

Explaining the decaffeinate process was explained at the time that it mattered, during PR / peer review.

Once you figure out that you're going to decaffeinate stuff, you extract that part out of your PR and open a separate PR prior to merging the original. It's the best time to do it, so it's only done on the files that are affected by the PR. They need to be merged ahead of time so that the diff is accurate.

I took the files you worked in and decaffeinated them and then added them to develop - so that your PR's diff could be generated off of develop, to accurately portray the changes.