Allow video to be recorded till the end of the test

[bahmutov]

Adds hardcoded delay of 1 second after the end of the test run before closing the browser if there is video recording going on. This allows the last frames to be added, creating the complete video.

• Closes Video recorded is incomplete - last frames before tests are complete are not recorded #2370
• added separate debug stream DEBUG=cypress:server:video:frames for Electron video frames, which should give more insight into video freezing in Cypress UI locks up during cypress run in CI (recognizable in video recording, the UI is less responsive and/or completely frozen) #4722
• fully records video in https://github.com/bahmutov/cypress-test-clock
• fully records the repo from the original issue https://github.com/PinkyJie/cypress-auto-stub-example

Reviews

Trying something new

• initial review by @bkucera
• final review by @brian-mann

Before

the last frame of the video

After

Pre-merge Tasks

• Have tests been added/updated for the changes in this PR?
• Has the original issue been tagged with a release in ZenHub?

[jennifer-shehane]

eek. I know this likely solves the issue, but...hardcoded 1 sec wait is kind of the opposite of Cypress philosophy. This will slow down user's runs, especially those that have 100+ spec files. Would rather isolate the cause and somehow hook into knowing when the reporter is done rendering to stop the video there.

[bahmutov]

yeah, imperfect, but good enough for now to fix the immediate problem. The video recording will probably change how we capture and end the video. 1-second addition per spec is a fair price I feel.

[brian-mann]

We should only delay the end of the video if we are actually recording a video

[bahmutov]

@brian-mann in the file it checks if we are recording the video, if there is a better way

    .tap =>
      # ? is this the best way to determine if we are recording a video?
      # TODO rename "end" to something meaningful, like "videoCaptureEnd"
      return unless end

[brian-mann]

Def agree with your comments on making this much clearer