set node_env for production and add static asset tests #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-mann
approved these changes
Jul 28, 2019
There was a problem hiding this comment.
I'm going to approve this PR but I need to...
- manually check that
longStackTraces: truewill continue to work in bluebird whilst in production mode
Also @bkucera did you manually verify that without setting NODE_ENV=production your badString implementation failed? We need to be 100% sure that this build check properly catches regressions.
brian-mann
requested changes
Jul 28, 2019
brian-mann
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-merge Tasks
Have tests been added/updated for the changes in this PR?
ensure bluebird longStackTraces can be set in prod mode
Cypress.Promise.hasLongStackTraces()wastrueverify testStaticAssets will fail when NODE_ENV isn't
productionopen + tag issue for this PR