Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Decaffeinate cookies specs 2 #4871

Closed
wants to merge 8 commits into from

Conversation

jennifer-shehane
Copy link
Member

No description provided.

@jennifer-shehane
Copy link
Member Author

@bkucera I'm not sure what happened here because this coffee file clearly did not decaffeinate - yet it says that it did (by commenting at the top of the file) https://github.com/cypress-io/cypress/pull/4871/files#diff-75af7e5532992c328accca4c7e5942d5 what a mess

My terminal output when running bulk decaffeinate

npm run decaffeinate-bulk -- convert --file packages/driver/test/unit/cypress/cookies_spec.coffee --file packages/server/test/support/fixtures/projects/e2e/cypress/integration/cookies_spec.coffee --file packages/server/test/e2e/2_cookies_spec.coffee --file packages/driver/test/cypress/integration/commands/cookies_spec.coffee

> cypress@3.4.1 predecaffeinate-bulk /Users/jennifer/Dev/cypress
> shx cp .eslintrc.decaffeinate.js .eslintrc.js


> cypress@3.4.1 decaffeinate-bulk /Users/jennifer/Dev/cypress
> bulk-decaffeinate "convert" "--file" "packages/driver/test/unit/cypress/cookies_spec.coffee" "--file" "packages/server/test/support/fixtures/projects/e2e/cypress/integration/cookies_spec.coffee" "--file" "packages/server/test/e2e/2_cookies_spec.coffee" "--file" "packages/driver/test/cypress/integration/commands/cookies_spec.coffee"

Verifying that decaffeinate can successfully convert these files... (8 workers)
4/4
Finished in 2 seconds (Time: 2019-07-30T11:49:10+06:30)
Backing up files to .original.coffee... (8 workers)
4/4
Finished in 0 seconds (Time: 2019-07-30T11:49:10+06:30)
Renaming files from .coffee to .js... (8 workers)
4/4
Finished in 0 seconds (Time: 2019-07-30T11:49:10+06:30)
Generating the first commit: "decaffeinate: Rename cookies_spec.coffee and 3 other files from .coffee to .js"...
Moving files back... (8 workers)
4/4
Finished in 0 seconds (Time: 2019-07-30T11:49:11+06:30)
Running decaffeinate on all files... (8 workers)
4/4
Finished in 3 seconds (Time: 2019-07-30T11:49:14+06:30)
Deleting old files... (8 workers)
4/4
Finished in 0 seconds (Time: 2019-07-30T11:49:14+06:30)
Setting proper extension for all files... (8 workers)
4/4
Finished in 0 seconds (Time: 2019-07-30T11:49:14+06:30)
Generating the second commit: decaffeinate: Convert cookies_spec.coffee and 3 other files to JS...
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/js-codemod/transforms/arrow-function.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
1 skipped
3 ok
Time elapsed: 1.518seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/js-codemod/transforms/arrow-function-arguments.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
4 skipped
0 ok
Time elapsed: 1.181seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/js-codemod/transforms/no-vars.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
4 skipped
0 ok
Time elapsed: 1.268seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/jscodemods/transforms/fix-class-assign-construct.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
4 unmodified
0 skipped
0 ok
Time elapsed: 1.312seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/jscodemods/decaffeinate/fix-multi-assign-class-export.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
4 skipped
0 ok
Time elapsed: 1.292seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/jscodemods/decaffeinate/fix-implicit-return-assignment.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
2 unmodified
0 skipped
2 ok
Time elapsed: 1.604seconds 
Running jscodeshift script /Users/jennifer/Dev/cypress/node_modules/jscodemods/decaffeinate/fix-existential-conditional-assignment.js...
Processing 4 files... 
Spawning 4 workers...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
4 unmodified
0 skipped
0 ok
Time elapsed: 1.409seconds 
Running eslint --fix on all files... (8 workers)
4/4
Finished in 3 seconds (Time: 2019-07-30T11:49:28+06:30)
Generating the third commit: decaffeinate: Run post-processing cleanups on cookies_spec.coffee and 3 other files...
Successfully ran decaffeinate on 4 files.
You should now fix lint issues in any affected files.
All CoffeeScript files were backed up as .original.coffee files that you can use for comparison.
You can run "bulk-decaffeinate clean" to remove those files.
To allow git to properly track file history, you should NOT squash the generated commits together.

@cypress
Copy link

cypress bot commented Jul 30, 2019



Test summary

3324 0 47 1


Run details

Project cypress
Status Passed
Commit 1fd6a12
Started Jul 30, 2019 7:47 AM
Ended Jul 30, 2019 7:51 AM
Duration 03:51 💡
OS Linux Debian - 8.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title Decaffeinate cookies specs 2 [WIP] Decaffeinate cookies specs 2 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant