dont send focus events to hidden focusable elements #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuceb
commented
Aug 2, 2019
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
brian-mann
requested changes
Aug 2, 2019
mayfieldiv
reviewed
Aug 3, 2019
jennifer-shehane
previously approved these changes
Sep 24, 2019
brian-mann
requested changes
Sep 25, 2019
packages/driver/test/cypress/integration/e2e/focus_blur_spec.js
Outdated
Show resolved
Hide resolved
brian-mann
approved these changes
Sep 26, 2019
grabartley
pushed a commit
to grabartley/cypress
that referenced
this pull request
Oct 6, 2019
* dont send focus events to hidden focusable elements * refactor into isFocusableAndNotHidden * add w3c notes, rename method Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few notes:
.focuson a focusable element will not send events if the element isdisplay:noneorvisibility:hidden(or inherited from ancestor):visiblesince focusing an input of 0x0 size oropacity:0will still send focus eventsdisplay:noneneeds to be checked via walking up the parent nodes, whilevisibility:noneis inherited and can be checked withgetComputedStype(or$.css)tasks
W3CFocusablefor clarityPre-merge Tasks