Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix selector-playground css #4940

Merged
merged 5 commits into from
Aug 7, 2019
Merged

fix selector-playground css #4940

merged 5 commits into from
Aug 7, 2019

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Aug 6, 2019 •
edited
Loading

  • fixes regression introduced in 3.4.0 by webpack changes
  • also remove some async code since we no longer fetch the css at runtime
  • add a test to ensure the box gets drawn properly over the element

fix #4872

@cypress
Copy link

cypress bot commented Aug 6, 2019 •
edited
Loading


Test summary

3326 • 0 • 47 • 0

Run details
Project cypress
Status Passed
Commit 23492ee
Started Aug 7, 2019 4:27 PM
Ended Aug 7, 2019 4:33 PM
Duration 06:38 💡
OS Linux Debian - 8.10
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane
Copy link
Member 

/root/cypress/packages/runner/node_modules/yargs/yargs.js:1163
      else throw err
           ^

Error: Cannot find module '!../selector-playground/selector-playground.scss'

@kuceb kuceb merged commit 95b4e0d into develop Aug 7, 2019
@cypress-bot cypress-bot bot mentioned this pull request Aug 7, 2019
Closed
grabartley pushed a commit to grabartley/cypress that referenced this pull request Oct 6, 2019
@kuceb @grabartley
fix: fix selector-playground css (cypress-io#4940)
b033189 
* fix selector-playground css

* add selector_playground e2e spec

* add notes to webpack import syntax

* add notes to test

* fix runner unit tests: handle webpack imports
@emilyrohrbough emilyrohrbough deleted the fix-selector-playground branch August 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbreiding chrisbreiding chrisbreiding approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selector Playground doesn't highlight element currently being hovered over
3 participants
@kuceb @jennifer-shehane @chrisbreiding