WIP: add IE11 support #5224
Closed
WIP: add IE11 support #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrome serializes function as ‘function () {`, firefox as ‘firefox() {‘
the runner would sometimes shift upwards so that the header was hidden
firefox won’t load a nested iframe with the same src, so we have to trick it by using a ‘different’ url
only affected driver rerun_spec in interactive mode
# Conflicts: # packages/driver/package.json # packages/driver/test/cypress/integration/commands/actions/type_spec.coff ee # packages/driver/vendor/bililiteRange.js # packages/server/lib/browsers/chrome.coffee # packages/server/lib/project.coffee
* modify method of de-duping runner deps and upgrade deps * nevermind on path-based deps between driver/reporter/runner * fix tests broken by upgraded deps * remove unused var
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Those conflicts though 😓 |
This comment has been minimized.
This comment has been minimized.
|
Hey everyone, please add your comments about needing of this feature in the issue itself. #3207 The PR comments are critical for work concerning the code and implementation. We will need to lock down conversation to the team only since this is an important space to keep code discussions clean and readable. |
|
Unfortunately we have to close this PR due to inactivity - it's gone way out of date with the current develop. The work is still here to reference when needed in the future or can be reopened. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in backlog