Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-provided options immutability. #6459

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Feb 14, 2020

Breaking down #5762 into 3 PRs.

User facing changelog

  • Clone options object so that they're not mutated by the cy commands.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 14, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@sainthkh sainthkh force-pushed the issue-3171 branch 2 times, most recently from 85fa124 to 960f991 Compare February 17, 2020 08:13
@sainthkh sainthkh marked this pull request as ready for review February 18, 2020 08:17
@sainthkh sainthkh changed the title [WIP] User-provided options immutability. User-provided options immutability. Feb 18, 2020
@sainthkh

This comment has been minimized.

@sainthkh sainthkh requested a review from kuceb February 18, 2020 09:43
@sainthkh
Copy link
Contributor Author

I created #6459 and am waiting for review and merge.

@chrisbreiding chrisbreiding self-requested a review March 2, 2020 13:55
@kuceb
Copy link
Contributor

kuceb commented Mar 30, 2020

fixed some small issues I saw, trying to get this in

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks, @sainthkh!

@sainthkh
Copy link
Contributor Author

sainthkh commented Apr 7, 2020

@jennifer-shehane It's waiting to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone command options before passing into commands
4 participants