fix: inline element with visibile child now is considered visible #8130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Fixes an issue where a
display: inline
parent would be considered hidden if it had a visible child who haddisplay: block
Additional details
I do not think that implementing this fix is an appropriate course of action, see this comment in the original issue: #6183 (comment).Updated comment: #8130 (comment)I would like to have a discussion around this before we decide to merge these changes.
How has the user experience changed?
Given the following test case (modified here so may not work exactly, but shows the general idea, actual test case can be seen in diff):
Before:
After:
Given the original test case from the issue:
Before:
After:
PR Tasks