-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: XHR stub error if response json has number/boolean #9107
fix: XHR stub error if response json has number/boolean #9107
Conversation
Thanks for taking the time to open a PR!
|
…lean Signed-off-by: mrmodise <modisemorebodi@gmail.com>
316155e
to
ed7df85
Compare
I'm not sure why your PRs aren't triggering our circleCI tests. Maybe because you're force pushing? Maybe it's happening for other outside contributors? |
I checked a lot of them and they're failing but let me push without forcing and see the difference |
@jennifer-shehane still hangs 😢. Do we merge or rebase to include latest develop changes? |
I think its happening for other outside of contributors. I tried to trace the issue and all contributors' pipelines are passing. Big ups! CircleCI 😆 |
Usually you can do an empty commit to trigger the CI run if it didn't run the first time, but there may be something up with your commits that isn't triggering it. I made a commit to see if it will trigger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good if all the tests pass. Thanks for the fix! 👍
User facing changelog
Fixes an issue on XHR stub where by the response json has number/boolean primitives
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?