Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XHR stub error if response json has number/boolean #9107

Conversation

mrmodise
Copy link
Contributor

@mrmodise mrmodise commented Nov 5, 2020

User facing changelog

Fixes an issue on XHR stub where by the response json has number/boolean primitives

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2020

Thanks for taking the time to open a PR!

…lean

Signed-off-by: mrmodise <modisemorebodi@gmail.com>
@mrmodise mrmodise force-pushed the fix-xhr-stub-error-for-boolean-number-primitives branch from 316155e to ed7df85 Compare November 6, 2020 02:20
@jennifer-shehane
Copy link
Member

I'm not sure why your PRs aren't triggering our circleCI tests. Maybe because you're force pushing? Maybe it's happening for other outside contributors?

@mrmodise
Copy link
Contributor Author

mrmodise commented Nov 6, 2020

I'm not sure why your PRs aren't triggering our circleCI tests. Maybe because you're force pushing? Maybe it's happening for other outside contributors?

I checked a lot of them and they're failing but let me push without forcing and see the difference

@mrmodise
Copy link
Contributor Author

mrmodise commented Nov 6, 2020

@jennifer-shehane still hangs 😢. Do we merge or rebase to include latest develop changes?

@mrmodise
Copy link
Contributor Author

mrmodise commented Nov 6, 2020

I'm not sure why your PRs aren't triggering our circleCI tests. Maybe because you're force pushing? Maybe it's happening for other outside contributors?

I think its happening for other outside of contributors. I tried to trace the issue and all contributors' pipelines are passing. Big ups! CircleCI 😆

@jennifer-shehane jennifer-shehane self-requested a review November 6, 2020 10:00
@jennifer-shehane
Copy link
Member

Usually you can do an empty commit to trigger the CI run if it didn't run the first time, but there may be something up with your commits that isn't triggering it. I made a commit to see if it will trigger.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good if all the tests pass. Thanks for the fix! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on XHR stub if resonse json only contains a number or boolean
2 participants