Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rule no-debug #216

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

nicooprat
Copy link
Contributor

Addresses #74

It's basically a duplicate of no-pause.

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new rule no-debug to the README table Rules

@nicooprat
Copy link
Contributor Author

Done ✅ dd07e80 (#216)

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort order of rules needs correcting.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicooprat

Thanks for making the changes!

I tried out the rule on https://github.com/cypress-io/cypress-example-kitchensink and it worked fine.

From my side, this PR is now ready to merge!

@jennifer-shehane jennifer-shehane merged commit d58d93d into cypress-io:master Aug 12, 2024
7 checks passed
@cypress-app-bot
Copy link

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Collaborator

@nicooprat

Congratulations on the release of your rule! 🚀 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants