Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule): add no-focused-tests rule #82

Closed
wants to merge 2 commits into from

Conversation

jonathanchaffer
Copy link

Addresses #57.

@wachunga
Copy link

@bahmutov could you help get this merged? We have this for jest but not cypress.

@bahmutov
Copy link
Contributor

I prefer @chrisbreiding to merge these PRs

@klausbadelt
Copy link

At the risk "plus-1ing" this (shame on me) - would love to see this merged. Just forgot an .only all the way thru CI... 🤭

@bossley9
Copy link

bossley9 commented Mar 9, 2022

What is the status of this PR?

@DamienCassou
Copy link

What about using https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-exclusive-tests.md instead? Works fine for me.

@DamienCassou
Copy link

I've forked the project and welcome PRs: #100.

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023

CLA assistant check
All committers have signed the CLA.

@jonathanchaffer
Copy link
Author

Since it looks like this project is seeing some activity again, can we bump this?
cc @nagash77 @chrisbreiding

@nagash77 nagash77 self-assigned this Sep 11, 2023
@kasperjjit
Copy link

+1

@chiptus
Copy link

chiptus commented Mar 5, 2024

can we merge this?

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Apr 15, 2024

@jonathanchaffer

This PR has been pending for years!

I'm currently proposing some updates to this repo and I noticed this PR. I suggest instead of creating a new rule for eslint-plugin-cypress, use rules from eslint-plugin-mocha.

See the existing rules from eslint-plugin-mocha:

  • no-exclusive-tests which covers the use of .only much more extensively than this PR does.

This PR covers describe.onlyand it.only.

The eslint-plugin-mocha plugin covers the full set of possibilities: describe.only, it.only, suite.only, test.only, context.only and specify.only.

You can see an example of how eslint-plugin-cypress and eslint-plugin-mocha are combined In the cypress-io/cypress-example-kitchensink repo.

@sebb-m0
Copy link

sebb-m0 commented Apr 16, 2024

+1

@MikeMcC399
Copy link
Collaborator

@jonathanchaffer

To avoid duplicating the rules from eslint-plugin-mocha, the README section Mocha .only and .skip describes how to achieve the desired linting in a few simple steps.

The added documentation makes this PR no longer necessary, so I think it would make sense to close it now.

@MikeMcC399
Copy link
Collaborator

eslint-plugin-cypress@3.0.0 has been released and the README on the npm registry includes the instructions about how to test for .only and .skip, so as previously explained, this PR is now being closed.

@MikeMcC399 MikeMcC399 closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.