-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): add no-focused-tests rule #82
Conversation
@bahmutov could you help get this merged? We have this for jest but not cypress. |
I prefer @chrisbreiding to merge these PRs |
At the risk "plus-1ing" this (shame on me) - would love to see this merged. Just forgot an |
What is the status of this PR? |
What about using https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-exclusive-tests.md instead? Works fine for me. |
I've forked the project and welcome PRs: #100. |
2105818
to
019489f
Compare
Since it looks like this project is seeing some activity again, can we bump this? |
+1 |
can we merge this? |
This PR has been pending for years! I'm currently proposing some updates to this repo and I noticed this PR. I suggest instead of creating a new rule for See the existing rules from eslint-plugin-mocha:
This PR covers The eslint-plugin-mocha plugin covers the full set of possibilities: You can see an example of how |
+1 |
To avoid duplicating the rules from eslint-plugin-mocha, the README section Mocha The added documentation makes this PR no longer necessary, so I think it would make sense to close it now. |
eslint-plugin-cypress@3.0.0 has been released and the README on the npm registry includes the instructions about how to test for . |
Addresses #57.