Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yarn 1 (classic) examples #828

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR is related to issue #799 "Examples for Yarn 1 (Classic) and Yarn Berry / Modern (Version 2 and later)".

It provides new examples for Yarn Classic under the directories:

  • examples/yarn-classic
  • examples/v9/yarn-classic

together with a new corresponding workflow

  • example-yarn-classic.yml

an update to the following script to automate maintenance updates to cypress@latest

  • scripts/update-cypress-latest-other.sh

an update to cover both Yarn Classic (v1) and Yarn Modern (V2 and later) in the following file

  • .gitignore

and an update to

  • README.md

Verification

Local

nvm use 18 # for node v18.15.0
npm install yarn -g
yarn -v

expect 1.22.19

Yarn Classic with Cypress 9.7.0

From root of repository ...

cd examples/v9/yarn-classic
yarn
yarn test

Confirm Cypress test passes.

Yarn Classic with Cypress 12.7.0

From root of repository ...

cd examples/yarn-classic
yarn
yarn test

Update script

From root of repository ...

cd examples/yarn-classic
yarn add cypress@12.0.0 -D # install older version
cd ../..
npm run update:cypress
cd examples/yarn-classic
yarn list --pattern cypress

Confirm that Cypress has been updated to latest version (12.7.0).

GitHub

Manually run the workflow

  • example-yarn-classic.yml

and confirm success.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 13, 2023 10:09
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Mar 13, 2023

All manual tests pass.

I will follow up this PR with a Yarn Modern example PR. It is already prepared and needs this Yarn 1 (Classic) PR merging first. (See branch https://github.com/MikeMcC399/github-action/tree/feat/yarn-modern for preview.)

@mjhenkes mjhenkes assigned AtofStryker and unassigned mjhenkes Mar 14, 2023
@AtofStryker
Copy link
Contributor

@lmiller1990 do you mind taking a look at this one?

@lmiller1990 lmiller1990 self-requested a review March 17, 2023 03:57
@lmiller1990
Copy link
Contributor

Thanks!

@lmiller1990 lmiller1990 merged commit e77704d into cypress-io:master Mar 17, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Collaborator Author

@AtofStryker AtofStryker removed their assignment Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants