Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yarn berry / modern (version 2 and later) examples #838

Merged
merged 5 commits into from
Mar 19, 2023

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Mar 17, 2023

This PR is related to issue #799 "Examples for Yarn 1 (Classic) and Yarn Berry / Modern (Version 2 and later)" and it complements the Yarn 1 (Classic) examples added through PR #828.

It provides new examples for Yarn Modern under the directories:

  • examples/yarn-modern
  • examples/v9/yarn-modern

together with a new corresponding workflow

  • example-yarn-modern.yml
    an update to the following script to automate maintenance updates to cypress@latest

  • scripts/update-cypress-latest-other.sh

and an update to

  • README.md

Verification

Local

nvm use 18 # for node v18.15.0
npm install yarn -g
yarn -v

expect 1.22.19

Yarn Modern with Cypress 9.7.0

From root of repository ...

cd examples/v9/yarn-modern
yarn -v # should yield 3.4.1
yarn
yarn test

Confirm Cypress test passes.

Yarn Modern with Cypress 12.8.1

From root of repository ...

cd examples/yarn-modern
yarn -v # should yield 3.4.1
yarn
yarn test

Confirm Cypress test passes.

Update script

From root of repository ...

cd examples/yarn-modern
yarn add cypress@12.0.0 -D # install older version
cd ../..
npm run update:cypress
cd examples/yarn-modern
yarn info cypress --name-only

Confirm that Cypress has been updated to latest version (12.8.1).

GitHub

Manually run the workflow

  • example-yarn-modern.yml

and confirm success.

@AtofStryker AtofStryker requested a review from lmiller1990 March 17, 2023 21:20
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@lmiller1990 lmiller1990 merged commit d6a7839 into cypress-io:master Mar 19, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the feat/yarn-modern branch March 20, 2023 06:36
@MikeMcC399
Copy link
Collaborator Author

@lmiller1990

Many thanks for merging! Now that Yarn Classic and Modern are documented, I will follow up by documenting pnpm, which was not documented at all when support for this package manager was added to the action.

@MikeMcC399
Copy link
Collaborator Author

@lmiller1990

If you are able to, please follow the instructions in Updating the latest version in GitHub Marketplace since the Marketplace version is lagging behind at v5.3.1.

If not, then perhaps @jaffrepaul will need to take action?

@lmiller1990
Copy link
Contributor

Thanks @MikeMcC399, done! The marketplace now shows 5.5.1 as the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants