Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CYCLOUD-1447] Auto-detect PR numbers #1009
feat: [CYCLOUD-1447] Auto-detect PR numbers #1009
Changes from 39 commits
ade6071
afef3a6
2e6067c
d83963a
e277f50
6a7498b
1ccad80
12dcc6e
adebbb7
19380ba
9051d08
2e38a45
89fe794
9321be8
3a17a1f
d984062
d2df9c5
2aceb30
34055c5
a4ecbdd
44670f1
a28c1f3
b32c154
f9b9475
34aa09a
c63a89b
25c2040
6210cf7
73dc6c5
f0541c7
25b5378
75b5f49
7f93823
3995680
ee4e102
976d235
8456632
0ccc977
620df0d
74dbf08
d108631
7896153
0a94c6d
f8f90f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than focusing these sections around branches/PRs, it might make more sense to specify the behavior based on the various workflow event types.
For example, if the action executes on a
push
event, we'll still need to make the request, even if there is a PR open, as the GITHUB_HEAD_REF env will not be set for that event.We could do something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I'll update this 👍 That's much clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might also be worth adding a try/catch around this request in the event of a partial outage or something. I don't think we'd want to halt a recording by throwing in that case.