Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rework requirements for contributors #1010

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

MikeMcC399
Copy link
Collaborator

This PR adds a Requirements section to CONTRIBUTING.md and aligns with the wording used in cypress-io/cypress > CONTRIBUTING.md > Requirements.

The MAINTENANCE document now refers to the list of tools on node-version-usage to switch the version of Node.js based on .node-version instead of specifying the Node.js LTS version and suggesting the use of nvm and nvm-windows explicitly.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 29, 2023 10:20
@nagash77 nagash77 merged commit cda4525 into cypress-io:master Aug 29, 2023
@MikeMcC399 MikeMcC399 deleted the docs/requirements branch August 29, 2023 13:00
@github-actions
Copy link

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ax-vasquez added a commit that referenced this pull request Sep 1, 2023
* WIP - need to ask for ideal way to check existing variables

* check for existing variables

* consolidate comments

* remove yarn lock file

* run commands from PR feedback

* logging for testing purposes only

* more logging

* more logging

* simplify URL logic

* more logging

* remove logging - fix url string

* log response for fallback logic

* docs: rewrite readme working directory description (#1005)

* chore(deps): update dependency @types/node to v20.5.7 (#1008)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: rework requirements for contributors (#1010)

* feat(deps): update cypress to 13.0.0 (#1012)

* logging for testing purposes only

* test: run component test example from current branch (#1013)

* more logging

* more logging

* simplify URL logic

* more logging

* remove logging - fix url string

* log response for fallback logic

* cleanup

* doc update

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

* exit detectPrNumber if variables already defined

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

* docs update - formatting fix for readability

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

* try catch pr data request

* Readme update

* Update README.md

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

---------

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants