-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rework requirements for contributors #1010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nagash77
approved these changes
Aug 29, 2023
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ax-vasquez
pushed a commit
that referenced
this pull request
Aug 30, 2023
ax-vasquez
added a commit
that referenced
this pull request
Sep 1, 2023
* WIP - need to ask for ideal way to check existing variables * check for existing variables * consolidate comments * remove yarn lock file * run commands from PR feedback * logging for testing purposes only * more logging * more logging * simplify URL logic * more logging * remove logging - fix url string * log response for fallback logic * docs: rewrite readme working directory description (#1005) * chore(deps): update dependency @types/node to v20.5.7 (#1008) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: rework requirements for contributors (#1010) * feat(deps): update cypress to 13.0.0 (#1012) * logging for testing purposes only * test: run component test example from current branch (#1013) * more logging * more logging * simplify URL logic * more logging * remove logging - fix url string * log response for fallback logic * cleanup * doc update * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> * exit detectPrNumber if variables already defined * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> * docs update - formatting fix for readability * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> * try catch pr data request * Readme update * Update README.md Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> --------- Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Requirements section to CONTRIBUTING.md and aligns with the wording used in cypress-io/cypress > CONTRIBUTING.md > Requirements.
The MAINTENANCE document now refers to the list of tools on node-version-usage to switch the version of
Node.js
based on .node-version instead of specifying the Node.js LTS version and suggesting the use ofnvm
andnvm-windows
explicitly.