test: remove pnpm store caching #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
remove/pnpm-store-caching
branch
from
5d95993 to
0bb841c
Compare
|
Force pushed with no changes to test caching on subsequent runs. Test was successful. |
jennifer-shehane
approved these changes
May 27, 2024
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Workflows such as .github/workflows/example-basic-pnpm.yml, which attempt to cache the contents of the pnpm store, fail sporadically, especially after there has been a change in the version of Cypress and where pnpm workflow jobs are running in parallel.
If the cache of the pnpm store cache is loaded with the
cypressmodule, through steps outside of the Cypress GitHub action, and the Cypress binary has not been successfully cached by the action, then Cypress fails with a verification error.There is no mechanism available to coordinate these two different caching mechanisms. (See also #1179 (comment) for further explanation.)
Change
pnpm store caching is removed from the documentation:
README > pnpm
and replaced by text which recommends against this caching.
The following workflows are amended accordingly:
Related