Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update to semantic-release 24.1.0 #1244

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Aug 30, 2024

Issue

Although nothing was changed in the release job in the main workflow, there have been two recent failures releasing a new version of the action:

PR Release Job
#1239 6.7.3 29311414268
#1242 6.7.4 29370524987

In both cases a release tag was created, the release was added to the Releases list and then the action cycjimmy/semantic-release-action failed in the step adding released labels driven by @semantic-release/github.

The GitHub API error was:

Request quota exhausted for request GET /search/issues

The consequences are:

  1. Some closed issues / PRs may be missing a bot comment showing in which release the issue was resolved. Also a corresponding label released may be missing.
  2. The commits belonging to the release were not copied to the v6 branch, so the recommended invocation cypress-io/github-action@v6 pulls in the older v6.7.2 instead of the latest v6 tag.
  3. The CI badge shows failing (until the next successful commit to the master branch).

Background

Change

Add the option semantic_version: 24.1.0 to the parameters calling cycjimmy/semantic-release-action in the main workflow.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this Aug 30, 2024
@MikeMcC399 MikeMcC399 marked this pull request as ready for review August 30, 2024 07:09
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize you could pass this as an option. That makes sense.

@jennifer-shehane jennifer-shehane merged commit 496e7dc into cypress-io:master Aug 30, 2024
74 checks passed
Copy link

🎉 This issue has been resolved in version 6.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

It's good to see that the issue is now solved and the release went through without a hitch! Hopefully it will now be more reliable!

@MikeMcC399 MikeMcC399 deleted the update/semantic-release-24.1.0 branch August 30, 2024 12:50
@jennifer-shehane
Copy link
Member

Nice. I like when problems are already solved.

aayushshah15 pushed a commit to useblacksmith/cypress-io that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants