Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Removed hardlimit of 400MB #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed hardlimit of 400MB #2

wants to merge 1 commit into from

Conversation

Baterka
Copy link

@Baterka Baterka commented Apr 5, 2020

Acording to: https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy
There is no need for this hardlimit anymore. GitHub will begin evicting caches until the total size is less than 5 GB.

Acording to: https://help.github.com/en/actions/configuring-and-managing-workflows/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy
There is no need for this hardlimit anymore. GitHub will begin evicting caches until the total size is less than 5 GB.
@META-DREAMER
Copy link

@joshmgross Can we please get this merged? Causing cache misses for and really slowing down our CI/CD

@joshmgross
Copy link

👋 Hey @HammadJ,

This is a fork of actions/cache and not maintained by GitHub. Is there a specific feature that you need from this fork that isn't supported in actions/cache?

@META-DREAMER
Copy link

👋 Hey @HammadJ,

This is a fork of actions/cache and not maintained by GitHub. Is there a specific feature that you need from this fork that isn't supported in actions/cache?

@joshmgross Yes, this fork is used in this action: bahmutov/npm-install#27, which is what we are using in our workflow. That PR cant be merged until this one is updated to support the higher cache limit. Its PRs all the way down!

@joshmgross
Copy link

👋 Hey @HammadJ,
This is a fork of actions/cache and not maintained by GitHub. Is there a specific feature that you need from this fork that isn't supported in actions/cache?

@joshmgross Yes, this fork is used in this action: bahmutov/npm-install#27, which is what we are using in our workflow. That PR cant be merged until this one is updated to support the higher cache limit. Its PRs all the way down!

👍 Neither this repo nor the action you linked seem to be actively maintained. I'd recommend actions/setup-node and actions/cache.

@agilgur5
Copy link

agilgur5 commented Aug 10, 2020

@HammadJ see my PR bahmutov/npm-install#37 which upgrades to latest @actions/cache (which fixes this error) instead of relying on a PR to a fork as npm-install currently does. This fork and #1 was made as a workaround for actions#55, but that was resolved a couple months ago with actions#55 (comment).

The person you tagged has no association with this fork, they just happened to be someone that committed to the root repo and so is listed in the commit log. Pretty sure @bahmutov made this fork (associated with Cypress per bio, made the first PR) and hasn't maintained it since. It should be archived as this is misleading and my downstream PR merged to fix the error and remove this fork as a dependency.

👍 Neither this repo nor the action you linked seem to be actively maintained. I'd recommend actions/setup-node and actions/cache.

Unfortunately this does seem to be the case as my PR hasn't been responded to in 3+ weeks despite multiple @'s (and the original issues much longer)... Might have to keep another fork....

@agilgur5
Copy link

@bahmutov would be good to archive this repo entirely -- now that actions#55 has been solved and bahmutov/npm-install#37 was released -- in order to prevent confusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants