fix(deps): lock qs to 6.10.4

[MikeMcC399]

• closes qs@6.10.5 dependency issues deprecation warning #42

PR Checklist:

• I have run npm test locally and all tests are passing.
• I have added/updated tests for any new behavior.
  
• If this is a significant change, an issue has already been created where the problem / solution was discussed: qs@6.10.5 dependency issues deprecation warning #42

PR Description

• This PR changes the dependency qs from using a semver definition ~6.10.3 to using a fixed version 6.10.4 according to one option in the recommendation from qs@6.10.5:

$ npm view qs@6.10.5 deprecated
when using stringify with arrayFormat comma, [] is appended on single-item arrays. Upgrade to v6.11.0 or downgrade to v6.10.4 to fix.

• This PR supersedes fix(deps): update qs to 6.11.2 #43 as a low risk alternative to resolving qs@6.10.5 dependency issues deprecation warning #42, since it simply locks the minor version of qs to 6.10.4.

Notes

The PR does not change the version of qs chosen when installing @cypress/request with npm or pnpm.

The PR forces the choice of qs version made by Yarn so that it corresponds to the version choice made by npm and pnpm, which already resolve ~6.10.3 to the selection 6.10.4. This avoids that Yarn chooses the deprecated 6.10.5 version.

npm-pick-manifest mentions the algorithm whereby npm "Prefers non-deprecated versions to deprecated versions".

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[nagash77]

going to hold off on merging this until post Cy13 feedback dies down a bit. Don't want to introduce new possible vectors for problems that might mask Test Replay issues.

[MikeMcC399]

@nagash77

going to hold off on merging this until post Cy13 feedback dies down a bit. Don't want to introduce new possible vectors for problems that might mask Test Replay issues.

That is a very understandable tactic, given that:

• The issue affects only Yarn users, not npm or pnpm users.
• Apart from a deprecation warning there has been no feedback that a technical issue is caused.
• A workaround is available for Yarn users:

add the following to package.json:

  "resolutions": {
    "qs": "6.10.4"
  }

[nagash77]

@MikeMcC399 yeah I am seeing the same thing. Rerunning that build

[cypress-app-bot]

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀