Fix options bug

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## v5.2.1
+
+- Fix bug with providing options through e2e file, fixes [#267](https://github.com/cypress-visual-regression/cypress-visual-regression/issues/267)
+
 ## v5.2.0
 
 - Enable overriding pixelmatch options, fixes [#263](https://github.com/cypress-visual-regression/cypress-visual-regression/issues/263) and [#113](https://github.com/cypress-visual-regression/cypress-visual-regression/issues/113)

package.json

@@ -1,6 +1,6 @@
 {
  "name": "cypress-visual-regression",
- "version": "5.2.0",
+ "version": "5.2.1",
  "description": "Module for adding visual regression testing to Cypress",
  "keywords": [
  "visual regression",

src/command.ts

@@ -116,6 +116,12 @@ function prepareOptions(
  if (screenshotOptions.pixelmatchOptions !== undefined) {
  options.pluginOptions.pixelmatchOptions = screenshotOptions.pixelmatchOptions
  }
+ if (screenshotOptions.errorThreshold !== undefined) {
+ options.pluginOptions.errorThreshold = screenshotOptions.errorThreshold
+ }
+ if (screenshotOptions.failSilently !== undefined) {
+ options.pluginOptions.failSilently = screenshotOptions.failSilently
+ }
  // TODO refactor this in next release, separate plugin vs screenshot properties
  options.screenshotOptions = { ...screenshotOptions, ...commandOptions }
 

tests/integration/cypress/e2e/main.cy.ts

@@ -71,7 +71,7 @@ describe('Visual Regression Example', () => {
  it('should display the foo page incorrectly', () => {
  cy.on('fail', (error) => {
  if (error.message.includes("The 'bar' image is different.")) {
- expect(error.message).to.contain("Threshold limit of '0' exceeded")
+ expect(error.message).to.contain("Threshold limit of '0.007' exceeded")
  expect(error.message).to.contain(' - [Show Difference]')
  return
  }
@@ -213,7 +213,7 @@ describe('Visual Regression Example', () => {
  }
  expect(options.baseDirectory).to.equal('cypress/snapshots/base')
  expect(options.diffDirectory).to.equal('cypress/snapshots/diff')
- expect(options.pluginOptions.errorThreshold).to.equal(0)
+ expect(options.pluginOptions.errorThreshold).to.equal(0.007)
  expect(options.pluginOptions.failSilently).to.be.false
  expect(options.generateDiff).to.equal('fail')
  expect(options.screenshotAbsolutePath).to.exist

tests/integration/cypress/e2e/sub-folder/deep-spec.cy.ts

@@ -20,11 +20,7 @@ describe('Inner file within context', () => {
 describe('File name tests', () => {
  it('test file names', () => {
  cy.on('fail', (error) => {
- if (
- error.message.includes(
- "The 'files-1[2<3>4:5\"6\\7|8?9*10, 11]12(13)' image is different. Threshold limit of '0' exceeded"
- )
- ) {
+ if (error.message.includes("The 'files-1[2<3>4:5\"6\\7|8?9*10, 11]12(13)' image is different")) {
  return
  }
  throw error

tests/integration/cypress/support/e2e.ts

@@ -3,7 +3,7 @@ addCompareSnapshotCommand({
  pixelmatchOptions: {
  threshold: 0.1
  },
- errorThreshold: 0,
+ errorThreshold: 0.007,
  failSilently: false,
  capture: 'fullPage'
 })