Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Inspector.json instead of handwritten protocol.js #1

Merged
merged 5 commits into from
Sep 21, 2013

Conversation

sidorares
Copy link
Contributor

Instead of handwritten protocol.js now Inspector.json from webkit is used. Also included a simple repl

cyrus-and added a commit that referenced this pull request Sep 21, 2013
Use Inspector.json instead of handwritten protocol.js and include a simple REPL
@cyrus-and cyrus-and merged commit bc3150e into cyrus-and:master Sep 21, 2013
@cyrus-and
Copy link
Owner

Using Inspector.json and providing a REPL interface both seem good ideas. I accept this PR and I'll apply some fixes soon. Thank you Andrey.

@sidorares
Copy link
Contributor Author

Cool. I'm doing vim-based debugger with your module

@cyrus-and
Copy link
Owner

Glad to hear that! If it's ok for you I'd like to list you as a contributor in package.json.

@sidorares
Copy link
Contributor Author

Sure.

API feature request: list tabs (as a copy from connection phase or as a new http request) and switch to a new connection.

@cyrus-and
Copy link
Owner

API feature request: list tabs (as a copy from connection phase or as a new http request) and switch to a new connection.

I'll open an issue for that...

Edit: #2.

flotwig added a commit to flotwig/chrome-remote-interface that referenced this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants