MSVC attribute handling from perspective of packaging and public includes

[adamws]

The saslplug.h header uses __attribute__ which is not handled by msvc:

cyrus-sasl/include/saslplug.h

Line 107 in ef0bafd

void (*log)(sasl_conn_t *conn, int level, const char *fmt, ...) __attribute__((format(printf, 3, 4)));

I suppose this is why this exist:

cyrus-sasl/win32/include/config.h

Lines 137 to 138 in ef0bafd

	/* we're not gcc */
	#define __attribute__(foo)

The problem is that config.h is not part of installation and saslplug.h is, meaning that when packaged with conan for example, msvc users would get header which is not immediately usable.
I tested that by downloading cyrus-sasl from conancenter:

conan download 'cyrus-sasl/2.1.28#' -r conancenter --package-query="os=Windows" 

and checking how it is packaged:

$ tree
.
├── bin
│   └── sasl2.dll
├── conaninfo.txt
├── conanmanifest.txt
├── include
│   └── sasl
│       ├── exits.h
│       ├── gai.h
│       ├── hmac-md5.h
│       ├── md5global.h
│       ├── md5.h
│       ├── prop.h
│       ├── sasl.h
│       ├── saslplug.h
│       └── saslutil.h
├── lib
│   └── sasl2.lib
└── licenses
    └── COPYING

I think that there is a room for improvement here, i.e. public headers should contain platform-specific attribute handling.

[hyc]

Note - the same situation exists with mac/include/config.h. That all seems to be obsolete though, ever since MacOSX was released.

[hyc]

Ideally autoconf should test if __attribute__ is supported by the compiler. There used to be a test for this, but it was removed in 2e4af80 because redefining __attribute__ would break libc.

The correct fix would be to replace all uses of __attribute__ in the source with a Cyrus-SASL specific macro, so we can define it at will without affecting any other libraries. That's rather invasive but I think it's the right way to go. Also instead of the obsolete CMU-specific test, we can use autoconf's own test https://www.gnu.org/software/autoconf-archive/ax_c___attribute__.html