Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): enable poetry-dynamic-versioning and cz changelog #341

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Oct 27, 2023

Description

This set of changes allows poetry to automatically set the version during build. They also provide a commitizen configuration that allows for automatic changelog generation.

Closes #333

What is the nature of your change?

  • Enhancement (adds functionality).

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have deleted all non-relevant text in this pull request template.

@kenibrewer kenibrewer marked this pull request as ready for review October 27, 2023 18:53
@kenibrewer kenibrewer requested a review from d33bs October 27, 2023 18:54
@kenibrewer kenibrewer changed the title feat(build): enable poetry-dyanic-versioning and cz changelog feat(build): enable poetry-dynamic-versioning and cz changelog Oct 27, 2023
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions! I left a few comments that I was unsure enough about that I'd seek your input prior to moving forward with an approve. Please don't hesitate to let me know if you have any questions.

CITATION.cff Outdated Show resolved Hide resolved
.devcontainer/postCreateCommand.sh Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
This set of changes allows poetry to automatically set the version during build. They also provide a commitizen configuration that allows for automatic changelog generation.

Closes cytomining#333
@kenibrewer kenibrewer force-pushed the feat/automatic-versioning branch from dc4ae98 to 8483796 Compare October 28, 2023 13:27
@kenibrewer kenibrewer requested a review from d33bs October 28, 2023 13:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #341 (8483796) into main (871b633) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #341   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          56       56           
  Lines        3134     3135    +1     
=======================================
+ Hits         2990     2991    +1     
  Misses        144      144           
Flag Coverage Δ
unittests 95.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pycytominer/__about__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenibrewer kenibrewer self-assigned this Oct 28, 2023
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the replies and updates here - LGTM.

@kenibrewer kenibrewer merged commit 7b97db7 into cytomining:main Oct 29, 2023
10 checks passed
@kenibrewer kenibrewer deleted the feat/automatic-versioning branch October 29, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FeatureRequest: Add automatic versioning and changelog generation
3 participants