-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): enable poetry-dynamic-versioning and cz changelog #341
feat(build): enable poetry-dynamic-versioning and cz changelog #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions! I left a few comments that I was unsure enough about that I'd seek your input prior to moving forward with an approve. Please don't hesitate to let me know if you have any questions.
This set of changes allows poetry to automatically set the version during build. They also provide a commitizen configuration that allows for automatic changelog generation. Closes cytomining#333
dc4ae98
to
8483796
Compare
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 95.40% 95.40%
=======================================
Files 56 56
Lines 3134 3135 +1
=======================================
+ Hits 2990 2991 +1
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the replies and updates here - LGTM.
Description
This set of changes allows poetry to automatically set the version during build. They also provide a commitizen configuration that allows for automatic changelog generation.
Closes #333
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.