Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate Generation Settings #622

Closed
science695 opened this issue Aug 23, 2019 · 4 comments · Fixed by #647
Closed

Certificate Generation Settings #622

science695 opened this issue Aug 23, 2019 · 4 comments · Fixed by #647
Assignees

Comments

@science695
Copy link

Google and Apple are both making strides to put restrictions on SSL certificates. Things like cannot have more than 2 year expiration, must be certain key length....

On the latest Mac OS, they have implemented these changes which makes it reject the certificates created by devilbox.

I have looked and I do see that you already have these options available in cert-gen: https://github.com/devilbox/cert-gen/blob/master/bin/cert-gen

Would you be able to allow some of these options? -d or -k to be customized? Either an ENV variable that includes extra command line flags, or the option to override DEF_DAYS or DEF_KEYSIZE?

Would probably need to be in both apache and nginx docker images:
https://github.com/devilbox/docker-nginx-stable/blob/master/data/docker-entrypoint.d/08-cert-gen.sh
https://github.com/devilbox/docker-apache-2.4/blob/master/data/docker-entrypoint.d/08-cert-gen.sh

Currently the only problem I have is the expiration time of 10 years, but I feel like there may be more problems as the industry creates more and more stricter standards.

(Another option would be to reduce the DEF_DAYS=3650 to only 2 years or something smaller)

Thanks!

@stale
Copy link

stale bot commented Oct 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue:stale This issue has become stale and is marked for auto-close label Oct 22, 2019
@tmort
Copy link

tmort commented Oct 23, 2019

@science695 Following up on your original comment on allowing .env to set the -d flag when generating certificates, I've modified the apache2.4 docker image to allow this. You can read more at the following links:

Pull request for apache-2.4 Docker container
Description of the process and what it takes to install

@stale stale bot removed the issue:stale This issue has become stale and is marked for auto-close label Oct 23, 2019
@science695
Copy link
Author

@tmort Thanks! This looks great.

@cytopia
Copy link
Owner

cytopia commented Nov 30, 2019

This will be fixed in the upcoming release: #647

Apple had a few more requirements: https://support.apple.com/en-us/HT210176

@cytopia cytopia self-assigned this Nov 30, 2019
@cytopia cytopia mentioned this issue Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants