Ignore other mouse buttons during a left button gesture

Ref: "free" event doesn't fire if you right click during drag and drop #3005
cytoscape · Jun 18, 2024 · 7d845ee · 7d845ee
1 parent f6f28ee
commit 7d845ee
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/extensions/renderer/base/load-listeners.js b/src/extensions/renderer/base/load-listeners.js
@@ -398,6 +398,11 @@ BRp.load = function(){
   r.registerBinding( r.container, 'mousedown', function mousedownHandler( e ){
     if( !eventInContainer(e) ){ return; }
 
+    // during left mouse button gestures, ignore other buttons
+    if (r.hoverData.which === 1 && e.which !== 1) {
+      return;
+    }
+
     e.preventDefault();
 
     blurActiveDomElement();
@@ -833,6 +838,11 @@ BRp.load = function(){
 
   let clickTimeout, didDoubleClick, prevClickTimeStamp;
   r.registerBinding( containerWindow, 'mouseup', function mouseupHandler( e ){ // eslint-disable-line no-undef
+    // during left mouse button gestures, ignore other buttons
+    if (r.hoverData.which === 1 && e.which !== 1 && r.hoverData.capture) {
+      return;
+    }
+
     var capture = r.hoverData.capture;
     if( !capture ){ return; }
     r.hoverData.capture = false;