Fixes COSE TypeError by filtering the edges in the passed-in options #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(discards any edge that has a connected node not in the passed-in node collection) -- #3170
7 tasks
maxkfranz
reviewed
Oct 26, 2023
| const targetId = e.target().data('id'); | ||
| const hasSource = nodes.some((n) => n.data('id') === sourceId); | ||
| const hasTarget = nodes.some((n) => n.data('id') === targetId); | ||
| return !hasSource || !hasTarget; |
There was a problem hiding this comment.
Looks good.
FYI, you can use eles.has(someEle) so that you don't have to pull out IDs, but this is fine as-is.
maxkfranz
added a commit
that referenced
this pull request
Oct 26, 2023
Fixes COSE TypeError by filtering the edges in the passed-in options
|
Cherry-picked to master |
maxkfranz
added a commit
that referenced
this pull request
Oct 26, 2023
Fixes COSE TypeError by filtering the edges in the passed-in options Cherry-pick to 3.25.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues: #3170
Checklist
Author:
unstable. Bug-fix patches can go on eitherunstableormaster.Reviewers:
masterbranch and theunstablebranch. Normally, this just requires cherry-picking the corresponding merge commit frommastertounstable-- or vice versa.