Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rollup.config to bundle deps in esm.js #3221

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Change rollup.config to bundle deps in esm.js #3221

merged 1 commit into from
Feb 20, 2024

Conversation

ayjayt
Copy link
Contributor

@ayjayt ayjayt commented Feb 4, 2024

#3217

This pull request changes rollup config to bundle deps into the non min version of ESM.

why:

  • browsers can't import cjs, so all deps must be esm
  • not all deps to cytoscape are served as esm

@maxkfranz maxkfranz self-requested a review February 12, 2024 23:01
@maxkfranz maxkfranz mentioned this pull request Feb 14, 2024
Closed
7 tasks
@maxkfranz maxkfranz changed the title Change roll.config to bundle deps in esm.js Change rollup.config to bundle deps in esm.js Feb 20, 2024
@maxkfranz maxkfranz merged commit e8f6919 into cytoscape:unstable Feb 20, 2024
1 check passed
maxkfranz added a commit that referenced this pull request Feb 20, 2024
@maxkfranz
Update docs table for ESM build re. deps
dc2412b 
Ref:

- Improving ESM support and documentation, esp. for browsers #3217
- Change rollup.config to bundle deps in esm.js #3221
maxkfranz added a commit that referenced this pull request Feb 20, 2024
@maxkfranz
Add exports key in package.json
9bd7a73 
Ref:

- Improving ESM support and documentation, esp. for browsers #3217
- Change rollup.config to bundle deps in esm.js #3221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkfranz maxkfranz maxkfranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayjayt @maxkfranz