Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Do not require a project description on project create #777

Merged
merged 2 commits into from
May 2, 2018
Merged

Do not require a project description on project create #777

merged 2 commits into from
May 2, 2018

Conversation

cdosborn
Copy link
Contributor

@cdosborn cdosborn commented Apr 18, 2018 •
edited
Loading

Description

Remove requirement of projects to have a description

Resolves #634

Checklist before merging Pull Requests

  • Add an entry in the changelog
  • Reviewed and approved by at least one other contributor.

@cdosborn cdosborn requested a review from Tharon-C April 18, 2018 16:36
@cdosborn cdosborn self-assigned this Apr 18, 2018
Tharon-C
Tharon-C suggested changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@Tharon-C Tharon-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
One thing, if I edit the project details, in the edit form, the submit button is disabled unless the description field is populated. This is even after I change the name.

Tharon-C
Tharon-C suggested changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@Tharon-C Tharon-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
One thing, if I edit the project details, in the edit form, the submit button is disabled unless the description field is populated. This is even after I change the name.

@cdosborn cdosborn force-pushed the dont-require-description-on-project-create branch from 898c1b8 to d8172bf Compare April 18, 2018 21:18
@cdosborn
Copy link
Contributor Author

@Tharon-C good find. See the latest.

@cdosborn cdosborn mentioned this pull request May 2, 2018
Closed
@cdosborn cdosborn changed the base branch from master to v33 May 2, 2018 22:48
@cdosborn cdosborn merged commit 79ecc89 into cyverse:v33 May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tharon-C Tharon-C Tharon-C requested changes

Assignees

@cdosborn cdosborn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdosborn @Tharon-C