Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add norwegian pronouns (incomplete) #109

Draft
wants to merge 1 commit into
base: mistress
Choose a base branch
from

Conversation

adalinesimonian
Copy link

Adds support for Norwegian pronouns (both official written languages — Bokmål and Nynorsk).

I went to begin adding the necessary support on the website to support multiple locales, however I am encountering this error both in the browser and CLI when building the website:

Cannot read properties of undefined (reading 'startsWith')
  Stack trace:
    at connectionStringHasValidScheme (C:\Users\Adaline\GitHub\cyyynthia\pronoundb.org\node_modules\.pnpm\mongodb-connection-string-url@3.0.0\node_modules\mongodb-connection-string-url\lib\index.js:9:30)
    at parseOptions (C:\Users\Adaline\GitHub\cyyynthia\pronoundb.org\node_modules\.pnpm\mongodb@6.3.0\node_modules\mongodb\lib\connection_string.js:186:17)
    at file:///C:/Users/Adaline/GitHub/cyyynthia/pronoundb.org/packages/website/dist/server/chunks/pages/404_qEx_xJ8G.mjs:8:16
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async generatePages (file:///C:/Users/Adaline/GitHub/cyyynthia/pronoundb.org/node_modules/.pnpm/astro@4.2.1_@types+node@20.11.5_typescript@5.3.3/node_modules/astro/dist/core/build/generate.js:141:11)
 ELIFECYCLE  Command failed with exit code 1.

I didn't have time to investigate tonight, wondering if @cyyynthia you have any idea off the top of your head what might be the issue here.

@cyyynthia
Copy link
Owner

Hi there, first off thanks for looking into that and contributing to PronounDB!

I haven't gotten around to reviewing the code yet, but I'll let you know right off that I'm unsure about how i18n will go and there are a few things in the current structure I want to change, like the way text is rendered when "any" is involved. I wrote this on my Discord server which is still relevant:

Screenshot_20240207-085520.png

I want you to know that right off so you don't burn some of your time on it when there's a chance it'll stay on the shelf collecting dust until things are a bit clearer for me in terms of the direction this thing should go 😅

Regarding your issues, did you setup a .env file in packages/website?

capitalized: 'Andre',
},
},
spør: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite unsure about non-ascii identifiers here

@@ -177,7 +177,7 @@ const flash = handleFlash(Astro)
<p class='mb-2'>Each locale has a list of pronouns set available to it.</p>
<div class='flex flex-none gap-4 items-center mb-4 px-4 py-2 font-semibold border rounded text-blue-600 border-blue-600 dark:text-blue-400 dark:border-blue-400'>
<div class='w-6 h-6 shrink-0' set:html={infoIcon}/>
<p>Only the "en" locale is supported at this time.</p>
<p>Only the "en", "nb", and "nn" locales are supported at this time.</p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably best be replaced by some other message, as this was intended to outline the fact while the structure seems to indicate there may be multiple languages, only en is implemented.

The documentation should explain the canonical behavior for dealing with sets in multiple languages, what to pick etc. which is currently undefined as I haven't got around experimenting with it

@NoPlagiarism
Copy link

I want you to know that right off so you don't burn some of your time on it when there's a chance it'll stay on the shelf collecting dust until things are a bit clearer for me

What about adding new FAQ section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants