Skip to content

Commit 0237a91

Browse files
authored
Update packages for security vulnerabilities (#1193)
- update and remove unused packages - remove circleci cache binstub (doesn't work) - update stylesheets - update gem graph
1 parent 692e7b4 commit 0237a91

25 files changed

+177
-265
lines changed

.env-example

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export BASE_ECPM=400
77
export CAMO_HOST=
88
export CAMO_KEY=
99
export CAMPAIGN_DEMO_ID=395
10-
export CIRCLE_CI_TOKEN=
1110
export CLOUDFRONT_HOST=
1211
export CODEFUND_ANALYTICS_KEY=
1312
export DATABASE_URL=

Gemfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ gem "acts_as_commentable_with_threading", "~> 2.0.1"
1111
gem "aws-sdk-s3", "~> 1.61.1", require: false
1212
gem "barnes", "~> 0.0.7"
1313
gem "bootsnap", ">= 1.4.2", require: false
14-
gem "cable_ready", "~> 4.0.7"
14+
gem "cable_ready", "~> 4.0.9"
1515
gem "camo", "~> 0.1.0"
1616
gem "chroma", "~> 0.2.0"
1717
gem "chronic", "~> 0.10.2"

Gemfile.lock

+1-1
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ DEPENDENCIES
597597
bootsnap (>= 1.4.2)
598598
bullet
599599
byebug
600-
cable_ready (~> 4.0.7)
600+
cable_ready (~> 4.0.9)
601601
camo (~> 0.1.0)
602602
capybara (>= 2.15)
603603
chroma (~> 0.2.0)

app/javascript/src/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ require('channels')
66
import 'bootstrap'
77
import 'select2'
88
import 'moment'
9-
import 'trix'
109
import 'bootstrap-daterangepicker'
1110
import '../events'
1211
import './prefetch'

app/javascript/themes/current/stylesheets/application.scss

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
@import '~noty/src/noty';
44
@import '~noty/src/themes/mint';
55
@import '~bootstrap-daterangepicker/daterangepicker';
6-
@import '~trix/dist/trix';
7-
@import 'mixins';
6+
@import 'variables';
87
@import 'theme';
98
@import 'utilities';
109
@import 'components';

app/javascript/themes/current/stylesheets/components.scss

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
@import './components/accordians';
21
@import './components/autocomplete';
3-
@import './components/cards';
42
@import './components/checkbox_tree';
53
@import './components/creative_preview';
64
@import './components/dropdown';

app/javascript/themes/current/stylesheets/components/accordians.scss

-30
This file was deleted.

app/javascript/themes/current/stylesheets/components/cards.scss

-10
This file was deleted.

app/javascript/themes/current/stylesheets/components/checkbox_tree.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
display: grid;
55
grid-template-columns: auto 1fr;
66
grid-template-rows: auto 1fr;
7-
color: $primary;
7+
color: $color-primary;
88
}
99

1010
&__branch > i {

app/javascript/themes/current/stylesheets/components/tables.scss

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// =========== Base ===========
22
th[scope='col'] a {
3-
color: #1e2022;
43
text-decoration: none;
54
}
65

@@ -9,7 +8,11 @@ th[scope='col'] a {
98
display: block;
109
line-height: 0.7;
1110
cursor: pointer;
12-
color: #bdc5d1;
11+
color: $color-gray-500;
12+
13+
&:hover {
14+
color: $color-gray-700;
15+
}
1316
}
1417

1518
// =========== Pagination ===========

app/javascript/themes/current/stylesheets/mixins.scss

-11
This file was deleted.

app/javascript/themes/current/stylesheets/theme.scss

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
@import './theme_variables';
2-
31
// =========== Webpack ===========
42
@import '~animate.css/animate';
53
@import '~bootstrap-select/dist/css/bootstrap-select.min';
@@ -30,13 +28,13 @@ footer {
3028
}
3129

3230
.app-header-dark {
33-
background-color: #222230 !important;
31+
background-color: $color-gray-800 !important;
3432
}
3533

3634
li.menu-item.active {
3735
a.menu-link {
38-
color: #222230;
39-
background-color: #ffffff;
36+
color: $color-gray-800;
37+
background-color: $color-white;
4038
}
4139
}
4240

@@ -71,15 +69,11 @@ button.layout-button {
7169
flex-direction: column;
7270
min-width: 0;
7371
word-wrap: break-word;
74-
background-color: #fff;
72+
background-color: $color-white;
7573
background-clip: border-box;
76-
border: 1px solid rgba(20, 20, 31, 0.12);
77-
border-radius: 0.25rem;
7874
}
7975

8076
.form-group {
81-
$color-danger: rgb(183, 107, 163);
82-
$color-danger-light: rgba(183, 107, 163, 0.15);
8377
.field_with_errors {
8478
label {
8579
color: $color-danger;
@@ -97,8 +91,14 @@ button.layout-button {
9791

9892
.app-header,
9993
.auth-header {
100-
background-color: #15003e !important;
94+
background-color: $color-purple !important;
10195
background-image: url('../../../images/patterns/pattern2.svg');
10296
background-size: initial;
10397
background-repeat: repeat;
10498
}
99+
100+
.dashboard-grid-wrapper {
101+
display: grid;
102+
grid-gap: 10px 20px;
103+
grid-template-columns: repeat(auto-fit, minmax(300px, 1fr));
104+
}

app/javascript/themes/current/stylesheets/theme_variables.scss

-11
This file was deleted.

app/javascript/themes/current/stylesheets/utilities.scss

+13-19
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
// =========== Mixins ===========
2+
@mixin media-breakpoint-down($name, $breakpoints: $grid-breakpoints) {
3+
$max: breakpoint-max($name, $breakpoints);
4+
@if $max {
5+
@media (max-width: $max) {
6+
@content;
7+
}
8+
} @else {
9+
@content;
10+
}
11+
}
12+
113
// =========== Opacity ===========
214
.opacity-0 {
315
opacity: 0 !important;
@@ -52,13 +64,9 @@
5264
}
5365
}
5466

55-
.text-sm {
56-
font-size: 0.825rem;
57-
}
58-
5967
.code {
6068
font-family: monospace;
61-
color: rgb(232, 62, 140);
69+
color: $code-text-color;
6270
word-break: break-word;
6371
font-size: 1.25em;
6472
}
@@ -85,28 +93,14 @@
8593
grid-template-columns: repeat(auto-fit, minmax(300px, 1fr));
8694
}
8795

88-
.grid-tcolumns-200 {
89-
grid-template-columns: repeat(auto-fit, minmax(200px, 1fr));
90-
}
91-
9296
.grid-trows-200 {
9397
grid-template-rows: repeat(auto-fit, minmax(200px, 1fr));
9498
}
9599

96-
.dashboard-grid-wrapper {
97-
display: grid;
98-
grid-gap: 10px 20px;
99-
grid-template-columns: repeat(auto-fit, minmax(300px, 1fr));
100-
}
101-
102100
// =========== Buttons ===========
103101
@include media-breakpoint-down(sm) {
104102
.btn-block-sm-only {
105103
display: block;
106104
width: 100%;
107105
}
108106
}
109-
110-
.bg-dark-ad {
111-
background-color: rgb(29, 29, 29);
112-
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
// =========== Color ===========
2+
$code-text-color: rgb(232, 62, 140);
3+
$color-danger-light: rgba(183, 107, 163, 0.15);
4+
$color-danger: #b76ba3;
5+
$color-primary: #346cb0;
6+
$color-purple: #15003e;
7+
$color-white: #ffffff;
8+
$color-gray-100: #f6f7f9;
9+
$color-gray-200: #e6e8ed;
10+
$color-gray-300: #d6d8e1;
11+
$color-gray-400: #c6c9d5;
12+
$color-gray-500: #a6abbd;
13+
$color-gray-600: #888c9b;
14+
$color-gray-700: #363642;
15+
$color-gray-800: #222230;
16+
$color-gray-900: #191927;
17+
18+
// =========== Breakpoints ===========
19+
$grid-breakpoints: (
20+
xs: 0,
21+
sm: 576px,
22+
md: 768px,
23+
lg: 992px,
24+
xl: 1200px
25+
) !default;

app/views/campaigns/show.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<iframe
1616
src="<%= @iframe_url %>"
1717
title="<%= @campaign.name %> Metabase dashboard"
18-
class="metabase-card"
18+
class="metabase-card border rounded"
1919
height="800"
2020
scrolling="yes"
2121
allowtransparency>

app/views/demos/show.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</div>
2525
<% end %>
2626
</div>
27-
<div class="<%= @theme.inquiry.dark? ? "bg-dark-ad text-white" : "bg-white" %> vw-100 pt-4">
27+
<div class="<%= @theme.inquiry.dark? ? "bg-dark text-white" : "bg-white" %> vw-100 pt-4">
2828
<div class="container w-full mx-auto d-flex flex-column">
2929
<h1>Ad Template: <%= @template.humanize %></h1>
3030
<p>

app/views/organizations/show.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<iframe
1414
src="<%= @iframe_url %>"
1515
title="<%= @organization.name %> Metabase dashboard"
16-
class="metabase-card"
16+
class="metabase-card border rounded"
1717
height="800"
1818
scrolling="yes"
1919
allowtransparency>

app/views/properties/show.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
please ensure ad blockers are disabled to view the overview
1212
</small>
1313
<iframe
14-
class="metabase-card"
14+
class="metabase-card border rounded"
1515
src="<%= @iframe_url %>"
1616
title="<%= @property.name %> Metabase dashboard"
1717
height="600px"

app/views/property_dashboards/show.html.erb

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<iframe
1212
src="<%= @iframe_url %>"
1313
title="<%= @property.name %> Metabase dashboard"
14-
style="width: 100%; border: 0; resize: horizontal;"
14+
class="metabase-card border rounded"
1515
height="800"
1616
scrolling="no"
1717
allowtransparency></iframe>

app/views/shared/_collapsible_search_form.html.erb

-29
This file was deleted.

bin/clear_circleci_cache

-18
This file was deleted.

gem_graph.png

-74.1 KB
Loading

0 commit comments

Comments
 (0)