Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the abstract class for stages. #173

Open
edyoshikun opened this issue Jun 21, 2023 · 2 comments
Open

Implement the abstract class for stages. #173

edyoshikun opened this issue Jun 21, 2023 · 2 comments
Assignees
Labels
feature request New feature or request

Comments

@edyoshikun
Copy link
Contributor

edyoshikun commented Jun 21, 2023

Similar to issue #166 and #167. The stages require an abstract class that should include the following:

-[ ] Get/Set position (already implemented but needs to be written in the abstract class)
-[ ] Get/Set relative position
-[ ] Get/Set maximium/miminum travel range
-[ ] Focus direction()?

We would probably need something for DAC controlled devices, but that is for a separate issue.

@AhmetCanSolak @yangjun9095 @ieivanov what do you think?

@edyoshikun edyoshikun added the bug Something isn't working label Jun 21, 2023
@edyoshikun edyoshikun self-assigned this Jun 21, 2023
@edyoshikun edyoshikun added documentation Improvements or additions to documentation feature request New feature or request and removed bug Something isn't working documentation Improvements or additions to documentation labels Jun 21, 2023
@AhmetCanSolak
Copy link
Contributor

We can implement for software triggered stages at first. Do you have such devices @edyoshikun ?

@edyoshikun
Copy link
Contributor Author

Sorry, I added the first prototoype to the abstract stage to the #162 PR. It should have been perhaps it's own PR. @AhmetCanSolak. I think the Thorlabs KCubes are a good example since we use them both in DaXi and mantis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants