-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration V2 #102
Registration V2 #102
Conversation
In the final version of the registration pipeline we should rotate the volumes by 90 deg such that they are in landscape mode rather than portrait mode (i.e. with larger width than height). Our brains process landscape aspect ratio more naturally and our monitors are built that way too. This is not critical now, but may affect some of the earlier design choices. |
@talonchandler let's schedule some time to go over this. Some design choices that we should also think about:
|
Excellent! @edyoshikun and I just finished a paired session and put together this list of (very superficial) TODO items. Thanks for all of your effort here @edyoshikun. @edyoshikun I've tagged you on the ones that you're best suited to handle. I'll handle the rest.
|
* refactor apply_affine * clean up Co-authored-by: Eduardo Hirata-Miyasaki <eduardo.hirata@czbiohub.org> * debug and add comments * updating estimate_affine to match new yml * don't start parallel pool for 1 iterable * patch previous commit * make sure the source_channel_used is first in the list for the optimizer * make optimize_affine accept the new config parameters * fix bug calling iohub info on paths with white spaces; rename target_channel_str * better white space cli bug fix * cleaner print statements * don't use itertools.starmap * clean up apply_affine print statements * clean up optimize_affine --------- Co-authored-by: Eduardo Hirata-Miyasaki <eduardo.hirata@czbiohub.org> Co-authored-by: Eduardo Hirata-Miyasaki <edhiratam@gmail.com>
…on into registration_v2
This PR adds the following:
TODO:
fry2
)keep_overhang: true
@edyoshikunestimate_affine
,optimize_affine
, andapply_affine
all take source and targets dirpaths, we no longer need to keepsource_shape_zyx
andtarget_shape_zyx
in the yml config file @edyoshikunutils
and into theregistration
andstabilization
modules @ieivanovFuture PRs:
target
tofixed
andsource
tomoving
to match convention in other image registration pipelinesestimate-affine
,optimize-affine
, andapply-affine
CLI calls toestimate-registration
,optimize-registration
, andregister
process_single_position_v2
andapply_transform_to_zyx_and_save_v2
(andaffine_transform
) to work on arrays of consistent shape - either ZYX or CZYX, not both. Possibly moveprocess_single_position
andapply_transform_to_zyx_and_save
toiohub
(long withupdate_scale_metadata
?). @talonchandler @ziw-liuapply_affine
handles positions will all nans or zeros. Currently we convert nans to zeros, which should not be necessary