Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bookmark-group): 增加分组功能,并重构命令注册部分 #35

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

czfadmin
Copy link
Owner

@czfadmin czfadmin commented Apr 4, 2024

在提出此拉取请求时,我确认了以下几点(请复选框):

  • 我已阅读并理解贡献者指南
  • 我已检查没有与此请求重复的拉取请求。
  • 我已经考虑过,并确认这份呈件对其他人很有价值。
  • 我接受此提交可能不会被使用,并根据维护人员的意愿关闭拉取请求。

填写PR内容:

  • 新增分组功能(默认分组不可修改和删除, 但支持调整排序)
    • 新增/ 删除/修改
    • 分组内书签拖拽
    • 分组拖拽排序
    • 增加设置默认激活组的功能: 当设置一个分组为默认激活组的时候, 新增加的书签将添加到默认激活的分组中
    • 快速跳转选择的分组的书签
    • 上下文调整书签所在的分组
  • 重构命令注册部分

分组显示
image
image

分组列表
image

上下文菜单调整分组
image

命令面板分组快速操作
image

设置默认激活的分组
image

@czfadmin czfadmin added the enhancement New feature or request label Apr 4, 2024
@czfadmin czfadmin self-assigned this Apr 4, 2024
@czfadmin czfadmin marked this pull request as draft April 4, 2024 17:14
/**
* @TODO 注册命令在 `editor` 中打开书签管理器中的数据
*/
export function openInEditor(args: any) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

暂未实现具体细节

@czfadmin czfadmin linked an issue Apr 5, 2024 that may be closed by this pull request
{
"command": "bookmark-manager.addBookmarkGroup",
"title": "%bookmark-manager.addBookmarkGroup%",
"when": "view == bookmark-manager",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后期某个版本在通用视图中增加分组管理功能

@czfadmin czfadmin marked this pull request as ready for review April 5, 2024 11:27
@czfadmin czfadmin merged commit 2c819bc into main Apr 5, 2024
2 checks passed
@czfadmin czfadmin changed the title feat(bookmark-group): 增加分组功能(WIP),并重构命令注册部分 feat(bookmark-group): 增加分组功能,并重构命令注册部分 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

分组功能
1 participant