Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies not flushed to disk when closing app immediately. Expose CookieManager.FlushStore method. #365

Closed
cztomczak opened this issue May 31, 2017 · 2 comments
Milestone

Comments

@cztomczak
Copy link
Owner

cztomczak commented May 31, 2017

Reported to occur on Windows 10 in examples: wxpython.py, qt.py and hello_world.py. This issue occurs when using ApplicationSettings.cache_path option. Cookies are not flushed when closing app immediately. Cookies are flushd to disk every 30 sec or so.

Reported issue on upstream CEF Forum:
https://magpcss.org/ceforum/viewtopic.php?f=6&t=16169

Original report on the CEF Python Forum:
https://groups.google.com/d/topic/cefpython/a7Mt-GqJEms/discussion

A similar issue was fixed in the v31 branch via Issue #158.

Issue occurs on Windows.
In v57 it worked fine on Linux, but in v66 the issue occurs also on Linux.

@cztomczak cztomczak changed the title Cookies not flushed to disk in the wxpython.py example on Windows Cookies not flushed to disk on Windows Jun 1, 2017
@cztomczak cztomczak changed the title Cookies not flushed to disk on Windows Cookies not flushed to disk when closing app immediately on Windows Feb 17, 2018
@cztomczak cztomczak added this to the v66 milestone May 22, 2018
@cztomczak
Copy link
Owner Author

cztomczak commented Aug 2, 2018

I can reproduce the issue on Windows 7 with the http://www.html-kit.com/tools/cookietester/ url. I've modified hello_world.py example and set cache_path option. If I set a cookie and close app within 30 seconds then the cookie is not persisted. If I wait 30 secs then I can see the cookie appear after relaunch.

Also reproducible with the wxpython.py example.
Also reproducible on Linux with the hello_world.py example.
Issue not reproducible in cefclient sample app.

@cztomczak cztomczak changed the title Cookies not flushed to disk when closing app immediately on Windows Cookies not flushed to disk when closing app immediately Aug 2, 2018
cztomczak added a commit that referenced this issue Aug 2, 2018
There are still some strange issues with CEF. For example I can
see that OnContextReleased is executed twice for that same frame.
@cztomczak cztomczak changed the title Cookies not flushed to disk when closing app immediately Cookies not flushed to disk when closing app immediately. Expose CookieManager.FlushStore method. Aug 2, 2018
cztomczak added a commit that referenced this issue Aug 2, 2018
@cztomczak
Copy link
Owner Author

cztomczak commented Aug 2, 2018

Fixed in rev c78619a.

If implementing custom cookie managers you have to call FlushStore explicitilly when closing associated browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant