GetCookieManager sometimes not called due to a race condition. API removed in latest CEF.

[cztomczak]

The GetCookieManager callback doesn't have browser parameter in upstream CEF. This param is set during synchronous browser creation in CreateBrowserSync [1], so it is not immediately available. See comment in request context handler in C++ [2] and the SetBrowser method. Fix needs to be applied in [3] with such code:

if cefBrowser.get():
    pyBrowser = GetPyBrowser(cefBrowser, "GetCookieManager")
else:
    pyBrowser = None

And app code needs to be aware that browser param in GetCookieManager may be None - API docs need to state that.

Issue originally reported on the forum:
https://groups.google.com/d/msg/cefpython/e3bFx1I5BZA/2ZM7jKk8AgAJ

Ref:
[1]

cefpython/src/cefpython.pyx

Line 908 in ebdb184

# Request context - part 2/2.

[2]

cefpython/src/client_handler/request_context_handler.h

Line 21 in 824d7ce

// Browser may be NULL when instantiated from cefpython.CreateBrowserSync.

[3]

cefpython/src/handlers/request_handler.pyx

Line 281 in 77c506b

cdef public CefRefPtr[CefCookieManager] RequestHandler_GetCookieManager(

[cztomczak]

This error happened to me as well when running wxpython.py example.

[cztomczak]

Fixing the error is not enough, because if browser is NULL then we can't call user callback, as it is assigned to that browser. It must be fixed so that GetCookieManager callback is always called.

[cztomczak]

The GetCookieManager API was removed from upstream CEF. You can no longer create an instance on CefCookieManager, instead you have to create a new instance of CefRequestContext and provide a different cache_path to have a separate cookie store. This and other NetworkService related changes were disucced in upstream: https://bitbucket.org/chromiumembedded/cef/issues/2622/implement-support-for-networkservice