Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default colors to be accessed without class instantiation #100

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

giovcandido
Copy link
Contributor

@giovcandido giovcandido commented Oct 29, 2022

I think this change would help people who want to write custom methods, but still make use of the default colors without having to create a dummy instance just to have access to it.

Copy link
Owner

@czue czue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, thanks. just a couple suggested tweaks

celery_progress/static/celery_progress/celery_progress.js Outdated Show resolved Hide resolved
celery_progress/static/celery_progress/celery_progress.js Outdated Show resolved Hide resolved
giovcandido and others added 2 commits November 11, 2022 11:20
Co-authored-by: Cory Zue <cory.zue@gmail.com>
Co-authored-by: Cory Zue <cory.zue@gmail.com>
@giovcandido
Copy link
Contributor Author

Thanks for the suggestions!

Made the changes. It's good to go now.

@czue
Copy link
Owner

czue commented Nov 11, 2022

👍 thanks!

@czue czue merged commit 11e1870 into czue:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants