Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved getMessageDetails to onSuccessDefault handler #67

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Moved getMessageDetails to onSuccessDefault handler #67

merged 1 commit into from
Nov 20, 2020

Conversation

eeintech
Copy link
Contributor

If approved, fixes #66

@eeintech eeintech mentioned this pull request Nov 17, 2020
Closed
@eeintech
Copy link
Contributor Author

What's missing for this PR to be merged?

@OmarWKH
Copy link
Collaborator

OmarWKH commented Nov 20, 2020

This PR along with #69 look good enough to fix the issue. I don't know if @EJH2 has further thoughts.

@czue czue merged commit e978695 into czue:master Nov 20, 2020
@czue
Copy link
Owner

czue commented Nov 20, 2020

sorry, no reason, was just giving time for others to review

@eeintech
Copy link
Contributor Author

No problem, thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czue czue czue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task Return Result Content
3 participants
@eeintech @OmarWKH @czue