feat(dbscan1d): Support sample weight #11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizeyan
force-pushed
the
master
branch
2 times, most recently
from
877530a to
eb1dc5f
Compare
d-chambers
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Hey @lizeyan, Thanks for the contribution! There is just one small issue with sorting the weights to make sure they apply to the correct samples then it should be good to go.
| if sample_weight is None: | ||
| sample_weight = np.ones_like(ar, dtype=np.float64) | ||
| else: | ||
| sample_weight = np.asarray(sample_weight, dtype=np.float64) |
There was a problem hiding this comment.
I think when sample_weight is defined, it also needs to be sorted like the array, otherwise the weights might not be applied to the points the user intended.
I suggest replacing lines 102-13 with this:
sort_inds = np.argsort(ar)
ar_sorted = ar[sort_inds]
sample_weight_sorted = sample_weight[sort_inds]
undo_sort = np.argsort(sort_inds)Then passing sample_weight_sorted to self_get_is_core in line 106.
There was a problem hiding this comment.
Yes, you are right. I have fix it
d-chambers
approved these changes
Aug 17, 2024
|
Looks good, thanks @lizeyan |
This was referenced Aug 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.