Add support for Troy

[aloisdg]

Hello,

I would like to identify card from Troy. You can get Troy traits on Wikipedia.

If you want to solve this issue, check this how-to guide.

Cheers,

[hey24sheep]

If I add "Troy" 3 tests fail because of the IINRange is same as other cards. As you can see "65" falls in these other providers.

What to do?

[
  {
    "issuingNetwork": "Discover Card",
    "iinRanges": "6011, 644-649, 65",
    "active": "Yes",
    "length": "16–19",
    "validation": "Luhn algorithm"
  },
  {
    "issuingNetwork": "RuPay",
    "iinRanges": "60, 65, 81, 82, 508",
    "active": "Yes",
    "length": "16",
    "validation": "Luhn algorithm"
  },
  {
    "issuingNetwork": "Troy",
    "iinRanges": "65, 9792",
    "active": "Yes",
    "length": "16",
    "validation": "Luhn algorithm"
  },
  {
    "issuingNetwork": "Verve",
    "iinRanges": "506099–506198, 650002–650027",
    "active": "Yes",
    "length": "16, 19",
    "validation": "Unknown"
  },
]

[torendil]

I believe it really is time to think about changing the output and the tests of cardidy. I'll work on that on friday

[aloisdg]

Same IIN Range means it is a co branded card. They should identify as both. The order is quite arbitrary. We tried to move the most specific one above the other. Visa Electron being before Visa is a good example of that.

[torendil]

Yeah, but I think we should give several cards as answers if we manage to meet several valid tests

[aloisdg]

@torendil this is what we already do:

[TestCase("6500020000000000", false, ExpectedResult = new[] { CardType.Verve, CardType.Discover, CardType.RuPay })]
[TestCase("6500100000000000", false, ExpectedResult = new[] { CardType.Verve, CardType.Discover, CardType.RuPay })]
[TestCase("6500270000000000", false, ExpectedResult = new[] { CardType.Verve, CardType.Discover, CardType.RuPay })]
[TestCase("65002700000000000", false, ExpectedResult = new[] { CardType.Discover })]
[TestCase("650027000000000000", false, ExpectedResult = new[] { CardType.Discover })]
[TestCase("6500270000000000000", false, ExpectedResult = new[] { CardType.Verve, CardType.Discover })]
public IEnumerable<CardType> ShouldIdentifyAsVerve(string cardNumber, bool useCheck) => Cardidy.Identify(cardNumber, useCheck: useCheck).ToArray();

source

[torendil]

My bad 😅 @hey24sheep you can correct those tests to include Troy, I believe

[aloisdg]

No problem. It happens to all of us. 👍

[hey24sheep]

My bad 😅 @hey24sheep you can correct those tests to include Troy, I believe

No worries, I have added a PR for Troy. Have a look, thanks :)