-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1: Vapor decoupling #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Nov 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First stable release of Pioneer. Pioneer have been under v0.x for a while and it has shown little major issues. This brings a bit more confidence for me to start introducing major improvements and changes.
This pull request is all about decoupling Pioneer and Vapor. Moving all integration into their own directories and as extensions. This decoupling should be allow usage with other frameworks and better customisations
Once all v1 pull request have been merged, I am hoping to release v1.0.0-rc.1 or v1.0.0-beta which will be available to use and play with (hopefully shine some light into uncaught issues). If no major issue come up, v1.0.0 should be released soon after.
Motivation
One of the goal is to allow more Web frameworks integrations. Vapor is a great Web framework, but similarly to Apollo Server, Pioneer should not strictly restrict itself to one framework.
At some point (possibly v2), Pioneer and its Vapor integration would be separate packages which allow user of the library to use other options if they see fit.
Another goal is catch up to Apollo Server v4 which have significant changes especially on the API of the library.
Changes
Configuration