save after setting parent

it should be the responsibility of the caller to save this, not the mixin code see the related ManageIQ/manageiq#20990
d-m-u · Jan 28, 2021 · 6d6c361 · 6d6c361
1 parent e174d80
commit 6d6c361
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/controllers/api/vms_controller.rb b/app/controllers/api/vms_controller.rb
@@ -103,9 +103,9 @@ def edit_resource(type, id, data)
       attrs = validate_edit_data(data)
       parent, children = build_parent_children(data)
       resource_search(id, type, collection_class(type)).tap do |vm|
-        vm.update!(attrs)
         vm.replace_children(children)
         vm.set_parent(parent)
+        vm.update!(attrs)
       end
     rescue => err
       raise BadRequestError, "Cannot edit VM - #{err}"