Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#340 from claudenm/a-few-example-cl…
Browse files Browse the repository at this point in the history
…arifications

A few example clarifications
  • Loading branch information
bigkraig authored Mar 5, 2018
2 parents bd537c4 + a66eeeb commit 835abd1
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
26 changes: 17 additions & 9 deletions docs/walkthrough.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ In this example, you'll
value: us-west-1
```

- `CLUSTER_NAME`: name of the cluster.
- `CLUSTER_NAME`: name of the cluster.

```yaml
- name: CLUSTER_NAME
Expand Down Expand Up @@ -108,16 +108,24 @@ In this example, you'll
wget https://raw.githubusercontent.com/coreos/alb-ingress-controller/master/examples/echoservice/echoserver-ingress.yaml
```

1. Alter the host field to a domain that you own in Route 53

Assuming you managed `example.com` in Route 53.
1. Edit the alb.ingress.kubernetes.io/subnets annotation to include at least two subnets. If you'd like to use external dns, alter the host field to a domain that you own in Route 53. Assuming you managed `example.com` in Route 53. *Note:* The security group you specify must have public http access on port 80.

```yaml
spec:
rules:
- host: echoserver.example.com
http:
paths:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
name: echoserver
namespace: echoserver
annotations:
alb.ingress.kubernetes.io/scheme: internet-facing
alb.ingress.kubernetes.io/subnets: subnet-1, subnet-2
alb.ingress.kubernetes.io/security-groups: sg-1
alb.ingress.kubernetes.io/tags: Environment=dev,Team=test
spec:
rules:
- host: echoserver.example.com
http:
paths:
```

1. Add tags to subnets where ALBs should be deployed.
Expand Down
2 changes: 1 addition & 1 deletion examples/alb-ingress-controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ spec:
# Maximum number of times to retry the aws calls.
# defaults to 20.
- name: AWS_MAX_RETRIES
value: 20
value: "20"
- name: POD_NAME
valueFrom:
fieldRef:
Expand Down

0 comments on commit 835abd1

Please sign in to comment.