Move validations done in the user controllers into DTO

apps/drec-api/src/guards/PermissionGuard.ts

@@ -42,6 +42,9 @@ export class PermissionGuard implements CanActivate {
     const request = context.switchToHttp().getRequest();
     let user: IUser;
     user = request.user;
+    if (!user) {
+      return false;
+    }
     if (request.url.split('/')[3] === 'register') {
       this.logger.verbose(`When ${request.url.split('/')[3]}`);
       if (request.body.organizationType === Role.ApiUser) {

apps/drec-api/src/pods/user/dto/create-user.dto.ts

@@ -1,6 +1,5 @@
-import { ApiProperty, PickType, IntersectionType } from '@nestjs/swagger';
+import { ApiProperty, PickType } from '@nestjs/swagger';
 import { UserDTO } from './user.dto';
-import { OrganizationDTO } from '../../organization/dto/organization.dto';
 import {
   IsNotEmpty,
   IsString,
@@ -11,6 +10,7 @@ import {
 } from 'class-validator';
 import { UserORGRegistrationData } from '../../../models';
 import { Match } from '../decorators/match.decorator';
+import { Trim } from '../../../transformers/string';
 // export class CreateUserDTO
 //   extends PickType(UserDTO, [
 //     'title',
@@ -36,10 +36,7 @@ import { Match } from '../decorators/match.decorator';
 // }
 
 export class CreateUserORGDTO
-  extends IntersectionType(
-    PickType(UserDTO, ['firstName', 'lastName', 'email'] as const),
-    PickType(OrganizationDTO, ['organizationType'] as const),
-  )
+  extends PickType(UserDTO, ['firstName', 'lastName', 'email'] as const)
   implements UserORGRegistrationData
 {
   @ApiProperty({ type: String })
@@ -58,6 +55,7 @@ export class CreateUserORGDTO
 
   @ApiProperty({ type: String })
   @IsString()
+  @Trim()
   @IsNotEmpty()
   orgName?: string;
 
@@ -91,4 +89,9 @@ export class CreateUserORGDTO
 
   @IsOptional()
   orgid?: number;
+
+  @ApiProperty({ type: String })
+  @IsString()
+  @IsNotEmpty()
+  organizationType: string;
 }

apps/drec-api/src/pods/user/user.controller.ts

@@ -52,6 +52,7 @@ import { Permission } from '../permission/decorators/permission.decorator';
 import { ACLModules } from '../access-control-layer-module-service/decorator/aclModule.decorator';
 import { Roles } from './decorators/roles.decorator';
 import { Role } from '../../utils/enums';
+import { IsEmail } from 'class-validator';
 
 @ApiTags('user')
 @ApiBearerAuth('access-token')
@@ -127,35 +128,6 @@ export class UserController {
     @Req() request: Request,
   ): Promise<UserDTO> {
     const user = request.user;
-    if (
-      userRegistrationData.organizationType === '' ||
-      userRegistrationData.organizationType === null ||
-      userRegistrationData.organizationType === undefined
-    ) {
-      throw new ConflictException({
-        success: false,
-        message: `organizationType should not be empty`,
-      });
-    }
-    if (
-      userRegistrationData.organizationType.toLowerCase() !=
-        'Buyer'.toLowerCase() &&
-      userRegistrationData.organizationType.toLowerCase() !=
-        'Developer'.toLowerCase() &&
-      userRegistrationData.organizationType.toLowerCase() !=
-        'ApiUser'.toLowerCase()
-    ) {
-      throw new ConflictException({
-        success: false,
-        message: `organizationType value should be Developer/Buyer/ApiUser`,
-      });
-    }
-    if (userRegistrationData.orgName.trim() === '') {
-      throw new ConflictException({
-        success: false,
-        message: `orgName should not be empty`,
-      });
-    }
     if (!userRegistrationData.api_user_id) {
       userRegistrationData.api_user_id = (user as any).api_user_id;
     }
@@ -233,14 +205,13 @@ export class UserController {
     @Param('token') token: IEmailConfirmationToken['token'],
     @Body() body: UpdateChangePasswordDTO,
   ): Promise<UserDTO> {
-    const emailregex =
-      /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z0-9-]+\.)+[a-zA-Z]{2,}))$/;
-    let emailConfirmation: any;
-    if (emailregex.test(token)) {
-      emailConfirmation = await this.userService.findOne({ email: token });
+    if (IsEmail(token)) {
+      const emailConfirmation = await this.userService.findOne({
+        email: token,
+      });
       return this.userService.changePassword(emailConfirmation, body);
     } else {
-      emailConfirmation = await this.emailConfirmationService.findOne({
+      const emailConfirmation = await this.emailConfirmationService.findOne({
         token,
       });
       if (!emailConfirmation) {

apps/drec-api/src/transformers/string.ts

@@ -0,0 +1,5 @@
+import { applyDecorators } from '@nestjs/common';
+import { Transform } from 'class-transformer';
+
+export const Trim = (): PropertyDecorator =>
+  applyDecorators(Transform((value?: string) => value?.trim()));