[Quest/Malawi Core] Android App : Sync Inactive recently changed Resources which are being filtered #74
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urces which are being filtered
|
@BuchiNy can redo the tests you did on syncing inactive resources on this branch, especially with patients |
sevenreup
requested changes
Jul 4, 2024
| sharedPreferencesHelper | ||
| .read(SharedPreferenceKey.LAST_SYNC_TIMESTAMP.name, null) | ||
| .isNullOrBlank() | ||
| .not() |
There was a problem hiding this comment.
Is initial sync is when the timestamp is null
There was a problem hiding this comment.
I don't understand what this means
Is initial sync is when the timestamp is null
There was a problem hiding this comment.
The timestamp is set after the initial sync, so if you want to check if a sync is an initial sync you have to check if the timestamp is null. On that line, you are negating which means this is more of a check if the sync is subsequent than the initial one. Check the implementation in SyncBroadcaster.kt
BuchiNy
approved these changes
Jul 5, 2024
sevenreup
deleted the
73-questmalawi-core-android-app-sync-inactive-recently-changed-resources-which-are-being-filtered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
Engineer Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide