Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link encounter with task #93

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Conversation

BuchiNy
Copy link

@BuchiNy BuchiNy commented Jul 30, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the fhircore app to verify my change fixes the issue and/or does not break the app

@BuchiNy BuchiNy linked an issue Jul 30, 2024 that may be closed by this pull request
@BuchiNy BuchiNy requested a review from sevenreup July 30, 2024 14:27
@BuchiNy BuchiNy requested a review from sevenreup August 5, 2024 12:36
@sevenreup
Copy link

@BuchiNy test the PR again with the changes that Comfort made, and just comment with Task ids that have the new reference set

@BuchiNy
Copy link
Author

BuchiNy commented Aug 7, 2024

@sevenreup : Task/ab8d9b68-0276-458a-a2ec-df134c07f7fc

extras.forEach { resource ->
if (resource is Encounter) {
val taskReference = backReference.asReference(ResourceType.Task).extractId()
val taskID = taskReference

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be one line, why are we creating a taskReference and the taskID?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright noted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sevenreup changes made

@BuchiNy BuchiNy merged commit 3890584 into mwcore-dev Aug 7, 2024
3 checks passed
@BuchiNy BuchiNy deleted the 92-link-encounter-with-a-task-id branch August 7, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link encounter with a task id
3 participants