Configurable torch color and SOS from pulley #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toggling the SOS morse code is moved to a pull down menu. Rational behind this: SOS morse is a rare use case, but triggering it is extremely easy and in most cases undesired. Tapping it is just to easy, especially with narrow bezels.
A color picker was introduced with an adapted palette of colours, mainly oriented on natural light sources. My use case here is that I use it as reading light in bed. A less bright color is easier for my eyes (and sleepiness) and less annoying for my wife ;)
Initially I had the morse code also in the customized color, but switched it back to white, since it is probably the most reasonable choice for this scenario.