Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-{28,29}: improve path injection routine #470

Merged
merged 1 commit into from
May 19, 2022
Merged

emacs-{28,29}: improve path injection routine #470

merged 1 commit into from
May 19, 2022

Conversation

d12frosted
Copy link
Owner

  1. Move it to a helper function to the EmacsBase class
  2. Be more verbose about injection process
  3. Use PATH helper provided by brew to simplify manipulations

@d12frosted
emacs-{28,29}: improve path injection routine
133a4a4 
1. Move it to a helper function to the EmacsBase class
2. Be more verbose about injection process
3. Use PATH helper provided by brew to simplify manipulations
@d12frosted
Copy link
Owner Author

I've canceled runs on unaffected Emacs versions.

@d12frosted d12frosted mentioned this pull request May 19, 2022
Closed
@d12frosted
Copy link
Owner Author

IMO it should be better with this change, so merging.

@d12frosted d12frosted merged commit f3dce49 into master May 19, 2022
@d12frosted d12frosted deleted the feature/verbose-path-injection branch May 19, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d12frosted