Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

persistent volume maxSize isn't persisted to ZK #5303

Closed
jdef opened this issue Mar 5, 2017 · 6 comments
Closed

persistent volume maxSize isn't persisted to ZK #5303

jdef opened this issue Mar 5, 2017 · 6 comments
Assignees
@jdef

Comments

@jdef
Copy link
Contributor

jdef commented Mar 5, 2017 •
edited
Loading

https://github.com/mesosphere/marathon/blob/366697b7274053b1612609d6c8e7b9810c7aaf27/src/main/scala/mesosphere/marathon/api/serialization/ContainerSerializer.scala#L112
@jdef jdef added this to the Marathon 1.4 milestone Mar 5, 2017
@jdef
Copy link
Contributor Author

jdef commented Mar 5, 2017

funny enough, the protobuf has a field called maxSize but volume serialization doesn't actually save it. however fromProto does appear to read it in.

whoever fixes this might want to consolidate the toProto and fromProto in the same source file - surely that played a part in oversight leading to this bug.

@jdef
Copy link
Contributor Author

jdef commented Mar 5, 2017

xref https://github.com/mesosphere/marathon/blob/366697b7274053b1612609d6c8e7b9810c7aaf27/src/main/scala/mesosphere/marathon/state/Volume.scala#L201

@jdef
Copy link
Contributor Author

jdef commented Mar 5, 2017 •
edited
Loading

https://phabricator.mesosphere.com/D577 (fix for master)

@jdef jdef self-assigned this Mar 5, 2017
@jdef
Copy link
Contributor Author

jdef commented Mar 5, 2017

blocking for D201

@jdef
Copy link
Contributor Author

jdef commented Mar 6, 2017

decided against relocating any toProto/fromProto code to make for an easier cherry-pick back to 1.4. relocation can happen after D577 lands

@timcharper timcharper mentioned this issue Mar 6, 2017
Closed
2 tasks
@jdef jdef added the sprint-7 label Mar 6, 2017
jdef added a commit that referenced this issue Mar 6, 2017
@jdef
Fixes maxSize protobuf serialiation bug for persistent volumes
6ce3541 
Summary:
unit test and fix for persistent vol maxsize proto serialization

#5303
MARATHON-1408

Test Plan: sbt test

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D577
jdef added a commit that referenced this issue Mar 6, 2017
@jdef
Fixes maxSize protobuf serialiation bug for persistent volumes
e59b8f9 
Summary:
unit test and fix for persistent vol maxsize proto serialization

#5303
MARATHON-1408

Test Plan: sbt test

Reviewers: aquamatthias, meichstedt, timcharper, jenkins, unterstein

Reviewed By: meichstedt, jenkins, unterstein

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D577
@jdef jdef closed this as completed Mar 6, 2017
@meichstedt
Copy link
Contributor

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1725. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jdef jdef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meichstedt @jdef